Added Makefile for mvn and updated the github workflow#86
Added Makefile for mvn and updated the github workflow#86Jay07GIT wants to merge 9 commits intovinyldns:masterfrom
Conversation
There was a problem hiding this comment.
Let's also update the pom.xml file to remove personal contact information since this is not a personal project.
So, let's remove the existing developers block and replace it with:
<developers>
<developer>
<name>VinylDNS Maintainers</name>
<email>vinyldns-core@googlegroups.com</email>
<organization>VinylDNS</organization>
<organizationUrl>https://github.com/vinyldns/vinyldns-java</organizationUrl>
</developer>
</developers>Additionally, we should update the scm information as follows:
<scm>
<connection>scm:git:git://github.com/vinyldns/vinyldns-java.git</connection>
<developerConnection>scm:git:ssh://github.com:vinyldns/vinyldns-java.git</developerConnection>
<url>http://github.com/vinyldns/vinyldns-java</url>
</scm>
|
Removed |
remerle
left a comment
remerle
left a comment
There was a problem hiding this comment.
Just take a look at the one change I recommended.
pom.xml
Outdated
| <goal>sign</goal> | ||
| </goals> | ||
| <configuration> | ||
| <keyname>${{ secrets.PUBLISH_SIGNING_KEY_NAME }}</keyname> |
There was a problem hiding this comment.
I don't believe this will be interpolated correctly. Moreover, the key identifier/name is not secret - it's necessarily published to centralized keyservers. You can just include it here as plaintext.
F6D171DC24C6EB30FCAC1E85AEF7D1D58E3C1B9A
The passphrase and private key data is obviously secret, though.
There was a problem hiding this comment.
Updated gpg key name as plaintext as recommended .
nspadaccino
requested review from
Aravindh-Raju,
JoshSEdwards and
nspadaccino
| <developers> | ||
| <developer> | ||
| <name>VinylDNS Maintainers</name> | ||
| <email>vinyldns-core@googlegroups.com</email> |
There was a problem hiding this comment.
I don't think we have access to this email. Maybe there's a different one we can use, or else we can just remove it
Jay07GIT
added
the
kind/enhancement
3 participants
Changes:-